Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Senate Membership #430

Open
camfairchild opened this issue May 16, 2024 · 0 comments · May be fixed by #490
Open

Fix Senate Membership #430

camfairchild opened this issue May 16, 2024 · 0 comments · May be fixed by #490
Labels
bug Something isn't working red team feature development, etc

Comments

@camfairchild
Copy link
Contributor

Describe the bug

The Senate is comprised of the top peers by Stake in the root subnet (SN0). This group is a governance group that is permitted to vote on proposals made by the Triumvirate.

The issue is that the Senate membership is never update outside of initially adding a key (and swapping, if applicable) to the subnet during the root registration call. This means that when a peer registers for the root subnet they are given a status of either Senate membership, and if their relative Stake changes above or below the threshold to join/leave the Senate, their membership is not updated.

To Reproduce

  1. Register in the root subnet with low Stake, but enough to register (i.e. lowest_peer.stake + \epsilon)
  2. Notice you are not in the Senate
  3. Add sufficient Stake to qualify for the Senate
  4. Notice you are still not in the Senate

Expected behavior

I would expect the membership status to change automatically or for a call to change it to reflect the Stake holdings of the root subnet peers.

Screenshots

No response

Environment

OS: NA, Runtime Version: 148

Additional context

No response

@camfairchild camfairchild added the bug Something isn't working label May 16, 2024
@distributedstatemachine distributedstatemachine added the red team feature development, etc label May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working red team feature development, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants