Filter migration StakingHotkey by non-zero stakes, bump spec version

opentensor · Jul 5, 2024 · f037dbc · f037dbc
1 parent dbea365
commit f037dbc
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 21 deletions.
diff --git a/pallets/subtensor/src/migration.rs b/pallets/subtensor/src/migration.rs
@@ -560,29 +560,31 @@ pub fn migrate_populate_staking_hotkeys<T: Config>() -> Weight {
         let mut storage_writes: u64 = 0;
 
         // Iterate through all Owner entries
-        Stake::<T>::iter().for_each(|(hotkey, coldkey, _stake)| {
+        Stake::<T>::iter().for_each(|(hotkey, coldkey, stake)| {
             storage_reads = storage_reads.saturating_add(1); // Read from Owner storage
-            let mut hotkeys = StakingHotkeys::<T>::get(&coldkey);
-            storage_reads = storage_reads.saturating_add(1); // Read from StakingHotkeys storage
-
-            // Add the hotkey if it's not already in the vector
-            if !hotkeys.contains(&hotkey) {
-                hotkeys.push(hotkey);
-                keys_touched = keys_touched.saturating_add(1);
-
-                // Update longest hotkey vector info
-                if longest_hotkey_vector < hotkeys.len() {
-                    longest_hotkey_vector = hotkeys.len();
-                    longest_coldkey = Some(coldkey.clone());
+            if stake > 0 {
+                let mut hotkeys = StakingHotkeys::<T>::get(&coldkey);
+                storage_reads = storage_reads.saturating_add(1); // Read from StakingHotkeys storage
+
+                // Add the hotkey if it's not already in the vector
+                if !hotkeys.contains(&hotkey) {
+                    hotkeys.push(hotkey);
+                    keys_touched = keys_touched.saturating_add(1);
+
+                    // Update longest hotkey vector info
+                    if longest_hotkey_vector < hotkeys.len() {
+                        longest_hotkey_vector = hotkeys.len();
+                        longest_coldkey = Some(coldkey.clone());
+                    }
+
+                    // Update the StakingHotkeys storage
+                    StakingHotkeys::<T>::insert(&coldkey, hotkeys);
+                    storage_writes = storage_writes.saturating_add(1); // Write to StakingHotkeys storage
                 }
-
-                // Update the StakingHotkeys storage
-                StakingHotkeys::<T>::insert(&coldkey, hotkeys);
-                storage_writes = storage_writes.saturating_add(1); // Write to StakingHotkeys storage
+
+                // Accrue weight for reads and writes
+                weight = weight.saturating_add(T::DbWeight::get().reads_writes(2, 1));
             }
-
-            // Accrue weight for reads and writes
-            weight = weight.saturating_add(T::DbWeight::get().reads_writes(2, 1));
         });
 
         // Log migration results

diff --git a/runtime/src/lib.rs b/runtime/src/lib.rs
@@ -139,7 +139,7 @@ pub const VERSION: RuntimeVersion = RuntimeVersion {
     //   `spec_version`, and `authoring_version` are the same between Wasm and native.
     // This value is set to 100 to notify Polkadot-JS App (https://polkadot.js.org/apps) to use
     //   the compatible custom types.
-    spec_version: 158,
+    spec_version: 159,
     impl_version: 1,
     apis: RUNTIME_API_VERSIONS,
     transaction_version: 1,