Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BIT-598] Validator debug response table #999

Merged
merged 21 commits into from
Nov 20, 2022

Conversation

opentaco
Copy link
Contributor

@opentaco opentaco commented Nov 18, 2022

BIT-598 Validator debug response table

Adds an additional debug table to core_validator... --logging.debug that samples query tasks and server responses, formats it compactly, and displays the topk predicted phrases with probabilities.

The intended use of this table is to monitor and confirm proper query handling by displaying actual response content. This can also help to detect response anomalies that can help identify various new code/system/network errors that may have been introduced.

Apart from a task selection the table also includes overall step statistics for responsive servers.

Rich MarkupError exceptions are infrequently caught and handled when special characters in the task representation corrupt added markup.

Screenshot 2022-11-18 at 12 32 39

Screenshot 2022-11-18 at 12 39 22

@opentaco opentaco requested review from Eugene-hu, shibshib and isabella618033 and removed request for Eugene-hu and shibshib November 18, 2022 10:46
Copy link
Contributor

@Eugene-hu Eugene-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@opentaco opentaco merged commit f871314 into nobunaga Nov 20, 2022
@opentaco opentaco deleted the feature/BIT-598/validator-debug-response-table branch November 20, 2022 07:48
@opentaco opentaco mentioned this pull request Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants