Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hotfix] Fix CUDA Reg update block #954

Merged
merged 5 commits into from
Oct 13, 2022
Merged

Conversation

camfairchild
Copy link
Collaborator

This PR hotfixes the update block portion of the CUDA registration

@eduardogr
Copy link
Contributor

I think that, even if this is a hotfix, we need a test that could verify that this change is safe.
Do we have it? Do you think it's worthy to write a test here?

Copy link
Contributor

@eduardogr eduardogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great job @camfairchild , nice catch!

@camfairchild camfairchild added do not merge bug Something isn't working and removed do not merge labels Oct 13, 2022
@camfairchild camfairchild merged commit eb7aea2 into master Oct 13, 2022
@camfairchild camfairchild deleted the hotfix/reg_update_block branch November 15, 2022 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants