Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add check to add ws:// if needed #896

Merged
merged 2 commits into from
Sep 2, 2022
Merged

add check to add ws:// if needed #896

merged 2 commits into from
Sep 2, 2022

Conversation

camfairchild
Copy link
Collaborator

@camfairchild camfairchild commented Sep 1, 2022 •
edited
Loading

This change allows wss://chain_endpoints to be specified
e.g. btcli overview --subtensor.chain_endpoint wss://subtensor.exmaple.org

@camfairchild camfairchild marked this pull request as ready for review September 1, 2022 21:24
Eugene-hu
Eugene-hu approved these changes Sep 2, 2022
View reviewed changes
Copy link
Contributor

@Eugene-hu Eugene-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@camfairchild camfairchild merged commit 9aefc9e into nobunaga Sep 2, 2022
@camfairchild camfairchild mentioned this pull request Sep 2, 2022
Merged
@camfairchild camfairchild deleted the fix/allow-wss-chain-endpoints branch October 5, 2022 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eugene-hu Eugene-hu Eugene-hu approved these changes

@shibshib shibshib Awaiting requested review from shibshib

@unconst unconst Awaiting requested review from unconst

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@camfairchild @Eugene-hu