[BIT-552] Validator improvements (nucleus permute, synergy avg) #889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Persist object variable self.permute_uids across forward calls, select num_endpoints uids each forward call, reset to new permutation of all UIDs once empty. Removes factors of variability between validators by ensuring each UID is queried the same number of times.
Assumes nucleus samples without replacement by permuting range(metagraph.n). Removes another factor of variability between validators, namely how many UIDs are sampled during each validator epoch, which is influenced by the validator speed.
Set synergy_scaling_law_power independent of scaling_law_power, since synergy likely needs a higher power after synergy averaging.
Synergy averaging now significantly reduces synergy Shapley contribution compared to the base Shapley value, so the power needs to be increased to compensate.
isabella618033
approved these changes
Aug 29, 2022
shibshib
approved these changes
Aug 30, 2022
|
Great PR @opentaco , should we merge this to Nobunaga if we're testing on Nobunaga testnet? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BIT-552 Validation improvements
Minor validator fixes for rich table display delimitation, counting responsive UID when first encountered, and skipping repeat metagraph syncs.
Major validator improvements removing factors of variability:
metagraph.n(e.g. 4096) and consumes subsets from order to ensure each UID is queried once.synergy_scaling_law_powerparameter is introduced.synergy_scaling_law_poweris increased from 0.5 to 0.6 to compensate for averaging producing much lower synergy values compared to base Shapley values.