Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add E2E faucet test #1987

Merged
merged 10 commits into from
Jun 11, 2024
Merged

Add E2E faucet test #1987

merged 10 commits into from
Jun 11, 2024

Conversation

opendansor
Copy link
Contributor

Description of the Change

Add an E2E test for a user with the faucet command.

Quantitative Performance Benefits

Testing to make sure this feature doesn't regress by accident.

Possible Drawbacks

None

Verification Process

The test passes.

@opendansor opendansor requested a review from a team June 7, 2024 04:54
@opendansor opendansor self-assigned this Jun 7, 2024
Copy link
Contributor

@roman-opentensor roman-opentensor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

tests/e2e_tests/utils.py Outdated Show resolved Hide resolved
@opendansor
Copy link
Contributor Author

This PR will have test failing until https://github.com/opentensor/subtensor/pull/515 is merged in.

@opendansor opendansor merged commit c4a4d51 into staging Jun 11, 2024
12 checks passed
@opendansor opendansor deleted the feature/opendansor/e2e-faucet-test branch June 11, 2024 22:36
@gus-opentensor gus-opentensor mentioned this pull request Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants