Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Nonce implementation improved #1976

Merged
merged 21 commits into from
Jun 12, 2024
Merged

Feat: Nonce implementation improved #1976

merged 21 commits into from
Jun 12, 2024

Conversation

ibraheem-opentensor
Copy link
Contributor

@ibraheem-opentensor ibraheem-opentensor commented Jun 4, 2024 •
edited

Updates nonce's implementation:

  • After bittensor 7.2, we nonces will converted to timestamps instead of monotonic numbers
  • The code will check the synapse bittensor version and branch off in verifying the correct nonce structure accordingly

@ibraheem-opentensor ibraheem-opentensor marked this pull request as ready for review June 5, 2024 18:19
mjurbanski-reef
mjurbanski-reef reviewed Jun 6, 2024
View reviewed changes
bittensor/axon.py Outdated Show resolved Hide resolved
bittensor/axon.py Outdated Show resolved Hide resolved
bittensor/axon.py Show resolved Hide resolved
@gus-opentensor gus-opentensor merged commit 2b2bd40 into staging Jun 12, 2024
11 of 12 checks passed
@gus-opentensor gus-opentensor mentioned this pull request Jun 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjurbanski-reef mjurbanski-reef mjurbanski-reef left review comments

@gus-opentensor gus-opentensor gus-opentensor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ibraheem-opentensor @mjurbanski-reef @gus-opentensor