Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support Wallet names with hyphens when passing password through ENV vars #1949

Merged
merged 4 commits into from
Jul 23, 2024
Merged

support Wallet names with hyphens when passing password through ENV vars #1949

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
81b6be8
support Wallet names with hyphens when passing password through ENV vars
mjurbanski-reef May 29, 2024
ef43caf
Merge branch 'staging' into support_hypens_when_passing_cold_pw
mjurbanski-reef Jun 21, 2024
b14510a
Merge branch 'staging' into support_hypens_when_passing_cold_pw
mjurbanski-reef Jun 27, 2024
b19d939
Merge branch 'staging' into support_hypens_when_passing_cold_pw
mjurbanski-reef Jul 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion bittensor/keyfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,7 @@ def get_coldkey_password_from_environment(coldkey_name: str) -> Optional[str]:
for env_name, env_value in os.environ.items()
if (normalized_env_name := env_name.upper()).startswith("BT_COLD_PW_")
}
return envs.get(f"BT_COLD_PW_{coldkey_name.upper()}")
return envs.get(f"BT_COLD_PW_{coldkey_name.replace('-', '_').upper()}")


def decrypt_keyfile_data(
Expand Down
3 changes: 2 additions & 1 deletion tests/unit_tests/test_keyfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -613,7 +613,8 @@ def test_deserialize_keypair_from_keyfile_data(keyfile_setup_teardown):
def test_get_coldkey_password_from_environment(monkeypatch):
password_by_wallet = {
"WALLET": "password",
"my_wallet": "password",
"my_wallet": "password2",
"my-wallet": "password2",
}

monkeypatch.setenv("bt_cold_pw_wallet", password_by_wallet["WALLET"])
Expand Down