Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix set_take message #1940

Merged
merged 2 commits into from
May 24, 2024
Merged

Fix set_take message #1940

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e80f9dc
chore - fix take message
ibraheem-opentensor May 24, 2024
5901f86
Improved err_msg
ibraheem-opentensor May 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions bittensor/commands/delegates.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1172,9 +1172,7 @@ def _run(cli: "bittensor.cli", subtensor: "bittensor.subtensor"):
new_take = float(new_take_str)

if new_take > 0.18:
bittensor.__console__.print(
"ERROR: Take value should be in the range of 0 to 18%"
)
bittensor.__console__.print("ERROR: Take value should be below 18%")
ibraheem-opentensor marked this conversation as resolved.
Show resolved Hide resolved
return

result: bool = subtensor.set_take(
Expand Down
1 change: 0 additions & 1 deletion bittensor/extrinsics/set_weights.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,6 @@ def set_weights_extrinsic(
return False, error_message

except Exception as e:
# TODO( devs ): lets remove all of the bittensor.__console__ calls and replace with loguru.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

bittensor.__console__.print(
":cross_mark: [red]Failed[/red]: error:{}".format(e)
)
Expand Down
1 change: 1 addition & 0 deletions contrib/RELEASE_GUIDELINES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ If you are new in this role, ask for the proper setup you need to run this proce
## Process of release

1. Create a branch called `release/VERSION`, having VERSION with the version to release.
1. Make sure twine is installed: `pip install twine`
1. Within the release branch:
1. Update the version executing:`./scripts/release/versioning.sh --update UPDATE_TYPE`
1. **UPDATE_TYPE** could be *major*, *minor* or *patch*.
Expand Down