-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add commit weights and reveal weights functions #1938
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add e2e test - encode data using SCALE codec
…s' into feature/opendansor/commit_weights
thewhaleking
requested changes
May 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bunch of little things. Overall good.
roman-opentensor
approved these changes
May 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small style fix required. Overall looks good!
thewhaleking
approved these changes
May 28, 2024
ibraheem-opentensor
pushed a commit
that referenced
this pull request
May 28, 2024
…ights Add commit weights and reveal weights functions
Closed
Closed
Merged
gus-opentensor
pushed a commit
that referenced
this pull request
Jun 5, 2024
…ights Add commit weights and reveal weights functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Add a feature to
commit
weights for specific subnet on the Bittensor network and also toreveal
weights for a specific subnet on the Bittensor network.For Example you can call:
$ btcli wt commit --netuid 1 --uids 1,2,3,4 --weights 0.1,0.2,0.3,0.4
to commit weights, and call
$ btcli wt reveal --netuid 1 --uids 1,2,3,4 --weights 0.1,0.2,0.3,0.4
to reveal the weights on a network.
Verification Process
Add test for coverage, and E2E test with a member of the Nucleus team to make sure compatibility on the calls to the blockchain.
Release Notes