less verbose handled synapse exceptions #1928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjurbanski-reef
force-pushed
the
less_verbose_synapse_exc
branch
from
c5ceb3f
to
fbf5a45
Compare
thewhaleking
approved these changes
May 24, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The traceback being printed for expected exceptions is making logs less readable, and perhaps more importantly, possibly affective production service performance.
bittensor performs eager formatting of each of the logging message, and in this case, even
traceback.format_exc()is used, which also has too lookup frames in stack, and open python code files etc to find the lines to print. This happens even iftracelog level is disabled.This patch prevents that from happening from explicitly thrown SynapseException subclasses, that is, e.g.
BlacklistedExceptionpreventing additional load and log noise.The unknown exceptions still have full stacktrace printed as before, as they are quite useful for debugging, but the exceptions thrown on purpose (SynapseException subclasses) don't need it.
This change is inspire by case presented by @cxmplex in opentensor/bittensor-subnet-template#88