fix error handling in blacklist processing #1916
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cxmplex
changed the title
cxmplex
changed the title
cxmplex
changed the title
cxmplex
changed the title
cxmplex
changed the title
|
Spoke with upstream devs about this as its more appropriate to fix it on SN side as it doesnt appear any function in part of the axon operation has its exceptions caught. this likely means the onus is on the sn dev to catch them and the existing pattern should not be modified. As a result, PR closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if attackers are able to cause an error in the blacklist function, as they can with the current subnet example code, this error will propagate downstream to here.
Please see my associated PR in the subnet example repository that addresses the default code having an exploitable line to force an error:
opentensor/bittensor-subnet-template#88