Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: e2e tests #1915

Merged
merged 11 commits into from
May 30, 2024
Merged

ci: e2e tests #1915

merged 11 commits into from
May 30, 2024

Conversation

orriin
Copy link
Contributor

@orriin orriin commented May 22, 2024

Runs the e2e tests in ci to catch regressions like #1914 before they're merged

@orriin orriin added the testing label May 22, 2024
@orriin orriin force-pushed the ci/e2e-tests branch 3 times, most recently from b517625 to 45c1666 Compare May 22, 2024 09:26
runs on ubuntu
@orriin orriin marked this pull request as ready for review May 22, 2024 11:14
@gus-opentensor
Copy link
Collaborator

@orriin taking a look!

strategy:
matrix:
rust-branch:
- nightly-2024-03-05
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this line need to be updated with new releases?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the rust version changes, yes

Copy link
Contributor

@opendansor opendansor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one call out is to either create a PR when/if rust version updates or let us know so we can update the rust version ourselves.

@orriin orriin merged commit 6675cd1 into staging May 30, 2024
12 checks passed
@orriin orriin deleted the ci/e2e-tests branch May 30, 2024 16:10
@gus-opentensor gus-opentensor mentioned this pull request Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants