-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: e2e tests #1915
ci: e2e tests #1915
Conversation
b517625
to
45c1666
Compare
runs on ubuntu
@orriin taking a look! |
strategy: | ||
matrix: | ||
rust-branch: | ||
- nightly-2024-03-05 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this line need to be updated with new releases?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the rust version changes, yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one call out is to either create a PR when/if rust version updates or let us know so we can update the rust version ourselves.
Runs the e2e tests in ci to catch regressions like #1914 before they're merged