Add setting delegate take #1903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsor into tests/e2e-tests-staging
gztensor
force-pushed
the
feat/set-takes-staging
branch
from
b76da20
to
a01175d
Compare
chore: adds req factory boy
distributedstatemachine
force-pushed
the
feat/set-takes-staging
branch
from
a01175d
to
ea61c25
Compare
distributedstatemachine
force-pushed
the
feat/set-takes-staging
branch
from
1c2194c
to
e2a1515
Compare
| self, | ||
| wallet: "bittensor.wallet", | ||
| hotkey_ss58: str, | ||
| take: int, |
There was a problem hiding this comment.
Is take supposed to be an int or a float? It's defined here as int, but it's referenced elsewhere (like extrinsics/delegation.py as float.
There was a problem hiding this comment.
This is correct. The user passes a a float via the cli, is is converted into a u16 int. So i think its right. The subtensor function should take a float , while the extrinsics should accept ints
gus-opentensor
approved these changes
May 20, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds setting delegate take functionality.
Command: