-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add setting delegate take #1903
Conversation
…nsor into tests/e2e-tests-staging
b76da20
to
a01175d
Compare
chore: adds req factory boy
a01175d
to
ea61c25
Compare
1c2194c
to
e2a1515
Compare
self, | ||
wallet: "bittensor.wallet", | ||
hotkey_ss58: str, | ||
take: int, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is take
supposed to be an int or a float? It's defined here as int
, but it's referenced elsewhere (like extrinsics/delegation.py
as float.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is correct. The user passes a a float via the cli, is is converted into a u16 int. So i think its right. The subtensor function should take a float , while the extrinsics should accept ints
This PR adds setting delegate take functionality.
Command: