Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: deprecated usage of Balances::transfer method #1886

Merged
merged 1 commit into from
May 15, 2024
Merged

fix: deprecated usage of Balances::transfer method #1886

merged 1 commit into from
May 15, 2024

Conversation

orriin
Copy link
Contributor

@orriin orriin commented May 15, 2024

transfer is removed and replaced with transfer_allow_death polkadot-js/apps#9854

@orriin orriin added the bug Something isn't working label May 15, 2024
@orriin orriin changed the base branch from master to staging May 15, 2024 17:08
camfairchild
camfairchild approved these changes May 15, 2024
View reviewed changes
Copy link
Collaborator

@camfairchild camfairchild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but perhaps we should be using keep alive

@orriin
Copy link
Contributor Author

orriin commented May 15, 2024

That would prevent sending the entire account bal. If you're sure, can change it :)

@gus-opentensor gus-opentensor merged commit 636ea67 into staging May 15, 2024
12 checks passed
@gus-opentensor gus-opentensor mentioned this pull request May 17, 2024
Merged
@distributedstatemachine distributedstatemachine deleted the fix/deprecated-method-usage branch May 22, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camfairchild camfairchild camfairchild approved these changes

@gus-opentensor gus-opentensor gus-opentensor approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@orriin @camfairchild @gus-opentensor