-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retrieving error types from the metadata of the Substrate palette "SubtensorModule" for the btcli console (logic) #1862
Retrieving error types from the metadata of the Substrate palette "SubtensorModule" for the btcli console (logic) #1862
Conversation
2b86049
to
a31da79
Compare
…btensorModule" for the btcli console (logic)
a31da79
to
ba4a700
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey man, this is a massive breaking change (changing subtensor.py
=> subtensor_module.py
). Can you elaborate on the namespace conflicts that necessitate this?
Hey man!
I hope these explanations help clarify the rationale behind the changes. I am open to further discussion and am willing to consider any other suggestions you might have for effectively addressing this issue. |
e3a36d3
to
ff9a752
Compare
…ort subtensor module as subtensor_module on bittensor package level
ff9a752
to
6979acf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
I decided to split #1859 into 2 PRs:
Also, I had to rename the
subtensor.py
module due to a conflict between the class name and the module name in the namespace. This will not affect users and will not impact their experience.