fix get_coldkey_password_from_environment resolving wrong password #1843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjurbanski-reef
force-pushed
the
fix_get_cw_passwd_env
branch
from
2082110
to
40ba3ed
Compare
gus-opentensor
approved these changes
May 15, 2024
|
Anything that needs to be done here to get this merged? I don't see any conflicts with staging, but should I keep hitting "Update branch" or is this good to go as is? |
|
@mjurbanski-reef please refresh branch and I will merge |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Description of the Change
Before this change if ENV had set
BT_COLD_PW_WALLET=1BT_COLD_PW_MY_WALLET=2Requesting
test_get_coldkey_password_from_environment("wallet")would not deterministically return either"1"or"2".Alternate Designs
Possible Drawbacks
Verification Process
added unit tests
Release Notes
get_coldkey_password_from_environmentwill no longer return passwords from ENV of wallets sharing the same suffix