fix get_coldkey_password_from_environment resolving wrong password #1843
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Description of the Change
Before this change if ENV had set
BT_COLD_PW_WALLET=1
BT_COLD_PW_MY_WALLET=2
Requesting
test_get_coldkey_password_from_environment("wallet")
would not deterministically return either"1"
or"2"
.Alternate Designs
Possible Drawbacks
Verification Process
added unit tests
Release Notes
get_coldkey_password_from_environment
will no longer return passwords from ENV of wallets sharing the same suffix