Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache get_decoder_class #1834

Merged
merged 8 commits into from
May 2, 2024
Merged

Cache get_decoder_class #1834

merged 8 commits into from
May 2, 2024

Commits on May 1, 2024

  1. Monkeypatch in the caching of get_decoder_class 

    Fixes #1833
    @thewhaleking
    thewhaleking committed May 1, 2024
    Configuration menu
    Copy the full SHA
    9e682dd View commit details
    Browse the repository at this point in the history

  2. Change cache to lru_cache to keep compatibility with Python 3.8 (cach… 

    …e was added in 3.9)
    @thewhaleking
    thewhaleking committed May 1, 2024
    Configuration menu
    Copy the full SHA
    33749e6 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. Added note to requirements to verify we do not change scalecodec unti… 

    …l verifying compatibility with the monkeypatch.
    @thewhaleking
    thewhaleking committed May 2, 2024
    Configuration menu
    Copy the full SHA
    5a3a0a6 View commit details
    Browse the repository at this point in the history

  2. Added whitespace before comments in requirements files.

    @thewhaleking
    thewhaleking committed May 2, 2024
    Configuration menu
    Copy the full SHA
    d3cd9b6 View commit details
    Browse the repository at this point in the history

  3. Requirements comments format change.

    @thewhaleking
    thewhaleking committed May 2, 2024
    Configuration menu
    Copy the full SHA
    04f6144 View commit details
    Browse the repository at this point in the history

  4. get_decoder_class can take either a str or a dict. We are only able t… 

    …o cache hashable args, so we need to verify we're only sending strings to the cached function. This does add a bit of overhead (type checking), but is still much faster than without.
    @thewhaleking
    thewhaleking committed May 2, 2024
    Configuration menu
    Copy the full SHA
    8deab63 View commit details
    Browse the repository at this point in the history

  5. Removed the wrapper, as we only ever send strings.

    @thewhaleking
    thewhaleking committed May 2, 2024
    Configuration menu
    Copy the full SHA
    238668e View commit details
    Browse the repository at this point in the history

  6. Removed empty parens

    @thewhaleking
    thewhaleking committed May 2, 2024
    Configuration menu
    Copy the full SHA
    05b2794 View commit details
    Browse the repository at this point in the history