Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Wallet overwrite functionality #1802

Merged
merged 4 commits into from
Apr 29, 2024
Merged

Conversation

ibraheem-opentensor
Copy link
Contributor

Bug: The --overwrite_coldkey was not working as expected when regenerating coldkeys: the user was still prompted to enter y/N to confirm the action

Description:

  • add_argument actions were storing the value False (even if the flag was passed as argument)
  • Fix is propagated to other applicable methods as well.

@ibraheem-opentensor ibraheem-opentensor changed the title Bug fix: Wallet overwrite functionality Fix: Wallet overwrite functionality Apr 18, 2024
@gus-opentensor
Copy link
Collaborator

@ibraheem-opentensor is it possible to include tests for this?

@gus-opentensor gus-opentensor merged commit affc5bf into staging Apr 29, 2024
12 checks passed
@gus-opentensor gus-opentensor mentioned this pull request Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants