Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging: Added _primary_loggers #1797

Merged
merged 9 commits into from
May 1, 2024

Conversation

ibraheem-opentensor
Copy link
Contributor

@ibraheem-opentensor ibraheem-opentensor commented Apr 16, 2024

Edited:

  • _primary_loggers replaced _name
  • Usage is updated for _name
  • Methods to add/remove loggers in _primary_loggers

@ibraheem-opentensor ibraheem-opentensor marked this pull request as ready for review April 16, 2024 20:33
Copy link
Contributor

@sepehr-opentensor sepehr-opentensor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The enabling/disabling of the primary logger is already handled by the state transition logic, you would really only have to replace self._name with a set of strings, and handle accordingly.

bittensor/btlogging/loggingmachine.py Show resolved Hide resolved
bittensor/btlogging/loggingmachine.py Outdated Show resolved Hide resolved
@ibraheem-opentensor ibraheem-opentensor changed the title Logging: Added first_party_loggers Logging: Added _primary_loggers Apr 16, 2024
@ibraheem-opentensor ibraheem-opentensor force-pushed the logging/abe/adding-first-party-loggers branch from 1a09f1f to a497f65 Compare April 17, 2024 16:41
@ifrit98
Copy link
Contributor

ifrit98 commented Apr 22, 2024

Documentation for this?

@ibraheem-opentensor
Copy link
Contributor Author

Thanks for pointing this out. I'll add documentation for this functionality and also discuss to get these docs (here) updated as well.

@gus-opentensor gus-opentensor merged commit 5412af0 into staging May 1, 2024
12 checks passed
@gus-opentensor gus-opentensor mentioned this pull request May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants