fix PR templates #1778
Merged
fix PR templates #1778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjurbanski-reef
force-pushed
the
pr_templates
branch
from
52def89
to
ac3b1c8
Compare
mjurbanski-reef
force-pushed
the
pr_templates
branch
from
ac3b1c8
to
3c85b16
Compare
gus-opentensor
approved these changes
Apr 10, 2024
gus-opentensor
approved these changes
Apr 17, 2024
|
Anything else here that needs to be done here before merge? |
|
@mjurbanski-reef |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug
No GH Issue to link.
The problem was that Contributing instruction stipulate using PR templates which do not work and in multiple places refer to Atom project.
Description of the Change
Alternate Designs
Throw the whole thing out - but that since PR templates can be helpful I rejected this idea.
Possible Drawbacks
No drawbacks over the present, broken state.
Verification Process
I have tested PR creation process on my fork
Example: https://github.com/mjurbanski-reef/bittensor/compare/master...backend-developers-ltd:bittensor:pydantic-v2-walkback?template=bug_fix.md
Release Notes