Axon fix #1586
Merged
Axon fix #1586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eugene-hu
approved these changes
Nov 20, 2023
bittensor/axon.py
Outdated
| # Start of catching all exceptions, updating the status message, and processing time. | ||
| except Exception as e: | ||
| # Log the exception for debugging purposes. | ||
| bittensor.logging.trace(f"Forward exception: {traceback.format_exc()}") | ||
| bittensor.logging.error(f"Forward exception: {traceback.format_exc()}") |
There was a problem hiding this comment.
Just a note, I think we should start making use of the different levels of logging, ie.
logging.error("Key Error")
logging.trace(traceback)
This way users will be notified when theres an error vs a developer being notified with the traceback of the full error
There was a problem hiding this comment.
Sweet, I'll change this
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catches a
KeyErrorexception where axon's do not have the route attached that is being queries.This causes issues downstream and makes the error difficult to identify.
Now return a synapse populated with 404 and a helpful error message.