-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix axon requests signature using metadata #1394
Conversation
Honours goes to Adrianmares for the majority of this fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! This looks good to me.
Should we also update the int version also in the Auth Interceptor to 510?
bittensor/bittensor/_axon/__init__.py
Line 308 in 8e3f932
if int(version) < 370: |
Well throw that in a different PR @ifrit98 |
Fix checks signature of requester during every call to text_prompting forward synapse using the signature generated on GRPC TCP channel creation.
This removes the possibility for man in the middle attacks where a malicious actor is capable of spoofing the keys of network validators.