Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metagraph sync warning update. avoid potential crash #1328

Merged
merged 1 commit into from
May 15, 2023

Conversation

ifrit98
Copy link
Contributor

@ifrit98 ifrit98 commented May 14, 2023

For some reason, if on full sync and there are no neurons. the torch.stack() calls would result in an uncaught exception.

Figured we should log/warn the user this is happening or we can raise an exception if desired. Just ran into this while writing the unittest for the metagraph.

@ifrit98 ifrit98 requested review from unconst and Eugene-hu May 14, 2023 22:16
Copy link
Contributor

@Eugene-hu Eugene-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ifrit98 ifrit98 merged commit ac1bd25 into text_prompting May 15, 2023
@ifrit98 ifrit98 deleted the metagraph_sync_warn branch May 30, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants