Bit 611 refactor validator logging #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isabella618033
changed the title
opentaco
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to separate the concern for logging formatting from the major stats calculation in the neuron/nucleus
(1) the log_utilities.py are currently placed in bittensor/_neuron/text/log_utilities.py which is much closer to the validator
(2) all the tables/console print are encapsulated in the class ValidatorLogger() , so when you are calling the functions in neuron/nucleus, it would be like self.vlogger.func()
(3) all the prometheus log are encapsulated in the class ValidatorPrometheus() , so when you are calling the functions in neuron/nucleus, it would be like self.vlogger.prometheus.func()
(4) Added doc strings