Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing GitHub workflow push docker #1011

Merged
merged 1 commit into from
Dec 6, 2022
Merged

Removing GitHub workflow push docker #1011

merged 1 commit into from
Dec 6, 2022

Conversation

eduardogr
Copy link
Contributor

  • Removing github workflow for pushing docker image

@eduardogr eduardogr changed the base branch from master to nobunaga November 24, 2022 21:00
camfairchild
camfairchild approved these changes Nov 25, 2022
View reviewed changes
Copy link
Collaborator

@camfairchild camfairchild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. Should be on circleCI instead

@eduardogr eduardogr force-pushed the sre/removing-github-workflow-push-docker branch 2 times, most recently from 13f46bc to eaca923 Compare November 25, 2022 21:58
Eugene-hu
Eugene-hu approved these changes Dec 6, 2022
View reviewed changes
Copy link
Contributor

@Eugene-hu Eugene-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, I agree. I think this consistently fails on github actions. Do we need another script to push to docker or is that depreciated?

@eduardogr
Copy link
Contributor Author

eduardogr commented Dec 6, 2022 •
edited
Loading

Yea, I agree. I think this consistently fails on github actions. Do we need another script to push to docker or is that depreciated?

Great! 🚀
@Eugene-hu In fact, i've created this script to release the docker image

@eduardogr eduardogr force-pushed the sre/removing-github-workflow-push-docker branch from eaca923 to b426a85 Compare December 6, 2022 16:12
@eduardogr eduardogr mentioned this pull request Dec 6, 2022
Closed
@eduardogr eduardogr merged commit b533959 into nobunaga Dec 6, 2022
@eduardogr eduardogr mentioned this pull request Dec 6, 2022
Merged
@eduardogr eduardogr deleted the sre/removing-github-workflow-push-docker branch December 14, 2022 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camfairchild camfairchild camfairchild approved these changes

@Eugene-hu Eugene-hu Eugene-hu approved these changes

@joeylegere joeylegere Awaiting requested review from joeylegere

@opentaco opentaco Awaiting requested review from opentaco

@unconst unconst Awaiting requested review from unconst

Assignees
No one assigned
Labels
release/3.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eduardogr @camfairchild @Eugene-hu