-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving the way we manage requirements #1003
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduardogr
requested review from
Eugene-hu,
shibshib,
opentaco,
isabella618033,
joeylegere and
unconst
and removed request for
Eugene-hu
November 22, 2022 16:53
eduardogr
changed the title
Improving the way we managing requirements
Improving the way we manage requirements
Nov 22, 2022
eduardogr
force-pushed
the
sre/improve-managing-requirements
branch
from
November 22, 2022 18:22
4c96627
to
8895ce8
Compare
Eugene-hu
approved these changes
Nov 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but the testing change might have showcased some new flaky tests. We should fix them asap.
eduardogr
force-pushed
the
sre/improve-managing-requirements
branch
from
November 25, 2022 22:25
8895ce8
to
77ba581
Compare
camfairchild
approved these changes
Nov 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
eduardogr
commented
Nov 30, 2022
opentaco
approved these changes
Dec 7, 2022
eduardogr
force-pushed
the
sre/improve-managing-requirements
branch
from
December 8, 2022 19:36
f342e04
to
032b1ae
Compare
…it requirements file and providing more make commands. Requirements are now placed within a new directory 'requirements'
eduardogr
force-pushed
the
sre/improve-managing-requirements
branch
from
December 8, 2022 19:38
032b1ae
to
7824972
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you going to find?
Why pinned versions?
We should know the quality of what we release so we need to know if the released version works or not.
If we let dependencies open and some update breaks the version, we are going to end up with a bittensor broken scenario. Potentially miners are going to have a different set of packages<=>version and we do not want that, we want to know as much as possible about what people is running.
What about updating packages?
Within the proposal of this change, packages updates will be related with a bittensor new version release and, of course, a dedicated branch and time to check if the new package version integrated is working along our basecode.
What i need form you reviewing this PR?
I need a double check that the pinned versions are the ones we want.
Thanks!
New ways to install bittensor in a development environment
Installing bittensor for a development environment
Installing bittensor with cubit