Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving the way we manage requirements #1003

Merged
merged 11 commits into from
Dec 8, 2022

Conversation

eduardogr
Copy link
Contributor

@eduardogr eduardogr commented Nov 22, 2022

What are you going to find?

  • Now all versions are pinned, no >= or > without an upper bound is used
  • Extracting dev requirements into a new file
  • Extracting cubit requirements into a new file
  • Moving requirements file to a new directory 'requirements'
  • New Makefile provided for development commands
    • creating a virtual env
    • removing packages from within the virtualenv
    • installing bittensor, bittensor[dev], bittensor[cubit]

Why pinned versions?

We should know the quality of what we release so we need to know if the released version works or not.
If we let dependencies open and some update breaks the version, we are going to end up with a bittensor broken scenario. Potentially miners are going to have a different set of packages<=>version and we do not want that, we want to know as much as possible about what people is running.

What about updating packages?

Within the proposal of this change, packages updates will be related with a bittensor new version release and, of course, a dedicated branch and time to check if the new package version integrated is working along our basecode.

What i need form you reviewing this PR?

I need a double check that the pinned versions are the ones we want.

Thanks!

New ways to install bittensor in a development environment

Installing bittensor for a development environment

python3 -m pip install '.[dev]'

Installing bittensor with cubit

python3 -m pip install '.[cubit]'

@eduardogr eduardogr marked this pull request as ready for review November 22, 2022 16:54
@eduardogr eduardogr changed the base branch from master to nobunaga November 22, 2022 16:54
@eduardogr eduardogr changed the title Improving the way we managing requirements Improving the way we manage requirements Nov 22, 2022
@eduardogr eduardogr force-pushed the sre/improve-managing-requirements branch from 4c96627 to 8895ce8 Compare November 22, 2022 18:22
Copy link
Contributor

@Eugene-hu Eugene-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but the testing change might have showcased some new flaky tests. We should fix them asap.

Copy link
Collaborator

@camfairchild camfairchild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@eduardogr eduardogr force-pushed the sre/improve-managing-requirements branch from f342e04 to 032b1ae Compare December 8, 2022 19:36
@eduardogr eduardogr force-pushed the sre/improve-managing-requirements branch from 032b1ae to 7824972 Compare December 8, 2022 19:38
@eduardogr eduardogr merged commit a92976f into nobunaga Dec 8, 2022
@eduardogr eduardogr mentioned this pull request Dec 8, 2022
@eduardogr eduardogr deleted the sre/improve-managing-requirements branch December 14, 2022 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants