Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contrib/RELEASE_GUIDELINES has broken link to the scripts directory #1821

Closed
thewhaleking opened this issue Apr 29, 2024 · 1 comment
Closed

contrib/RELEASE_GUIDELINES has broken link to the scripts directory #1821

thewhaleking opened this issue Apr 29, 2024 · 1 comment
Assignees
@thewhaleking

Comments

@thewhaleking
Copy link
Contributor

The contrib/RELEASE_GUIDELINES.md file lists ./scripts/... as the scripts directory (such as for release.sh), however, the scripts directory is actually bittensor/scripts, so the link should be ../scripts/...
@thewhaleking thewhaleking self-assigned this Apr 29, 2024
@thewhaleking
Copy link
Contributor Author

Also contrib/DEVELOPMENT_WORKFLOW.md has the line:

Updating version with major or minor: ./scripts/update_version.sh major|minor

However, this is not a script.

thewhaleking added a commit that referenced this issue Apr 29, 2024
@thewhaleking
Fix broken links for scripts directory in RELEASE_GUIDELINES.md #1821
3fe4845
gus-opentensor added a commit that referenced this issue Apr 30, 2024
@gus-opentensor
Merge pull request #1823 from opentensor/fix-broken-link-in-contrib/t…
e5cda03 
…hewhaleking

Fix broken link in contrib/RELEASE_GUIDELINES #1821
@gus-opentensor gus-opentensor mentioned this issue May 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thewhaleking thewhaleking

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thewhaleking