support Wallet names with hyphens when passing password through ENV vars

opentensor · May 30, 2024 · 5ff7584 · 5ff7584
1 parent 119bc8d
commit 5ff7584
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/bittensor/keyfile.py b/bittensor/keyfile.py
@@ -281,7 +281,7 @@ def get_coldkey_password_from_environment(coldkey_name: str) -> Optional[str]:
         for env_name, env_value in os.environ.items()
         if (normalized_env_name := env_name.upper()).startswith("BT_COLD_PW_")
     }
-    return envs.get(f"BT_COLD_PW_{coldkey_name.upper()}")
+    return envs.get(f"BT_COLD_PW_{coldkey_name.replace('-', '_').upper()}")
 
 
 def decrypt_keyfile_data(

diff --git a/tests/unit_tests/test_keyfile.py b/tests/unit_tests/test_keyfile.py
@@ -613,7 +613,8 @@ def test_deserialize_keypair_from_keyfile_data(keyfile_setup_teardown):
 def test_get_coldkey_password_from_environment(monkeypatch):
     password_by_wallet = {
         "WALLET": "password",
-        "my_wallet": "password",
+        "my_wallet": "password2",
+        "my-wallet": "password2",
     }
 
     monkeypatch.setenv("bt_cold_pw_wallet", password_by_wallet["WALLET"])