Merge pull request #1952 from opentensor/chore/opendansor/fix-commit-…

…reveal-e2e

Fix E2E test for Commit/Reveal with Salt flag

bittensor/commands/weights.py

@@ -26,8 +26,9 @@
 
 import numpy as np
 from rich.prompt import Prompt, Confirm
-import bittensor.utils.weight_utils as weight_utils
+
 import bittensor
+import bittensor.utils.weight_utils as weight_utils
 from . import defaults  # type: ignore
 
 
@@ -90,15 +91,21 @@ def _run(cli: "bittensor.cli", subtensor: "bittensor.subtensor"):
             uids=uids, weights=weights
         )
 
-        # Generate random salt
-        salt_length = 8
-        salt = list(os.urandom(salt_length))
-
-        if not Confirm.ask(
-            f"Have you recorded the [red]salt[/red]: [bold white]'{salt}'[/bold white]? It will be "
-            f"required to reveal weights."
-        ):
-            return False, "User cancelled the operation."
+        if not cli.config.is_set("salt"):
+            # Generate random salt
+            salt_length = 8
+            salt = list(os.urandom(salt_length))
+
+            if not Confirm.ask(
+                f"Have you recorded the [red]salt[/red]: [bold white]'{salt}'[/bold white]? It will be "
+                f"required to reveal weights."
+            ):
+                return False, "User cancelled the operation."
+        else:
+            salt = np.array(
+                [int(x) for x in re.split(r"[ ,]+", cli.config.salt)],
+                dtype=np.int64,
+            ).tolist()
 
         # Run the commit weights operation
         success, message = subtensor.commit_weights(

tests/e2e_tests/subcommands/weights/test_commit_weights.py

@@ -1,16 +1,18 @@
+import re
+import time
+
+import numpy as np
+
+import bittensor
+import bittensor.utils.weight_utils as weight_utils
 from bittensor.commands import (
     RegisterCommand,
     StakeCommand,
     RegisterSubnetworkCommand,
     CommitWeightCommand,
     RevealWeightCommand,
 )
-import bittensor
 from tests.e2e_tests.utils import setup_wallet
-import time
-import bittensor.utils.weight_utils as weight_utils
-import re
-import numpy as np
 
 
 def test_commit_and_reveal_weights(local_chain):
@@ -21,6 +23,7 @@ def test_commit_and_reveal_weights(local_chain):
     # define values
     weights = 0.1
     uid = 0
+    salt = "18, 179, 107, 0, 165, 211, 141, 197"
 
     # Verify subnet 1 created successfully
     assert local_chain.query("SubtensorModule", "NetworksAdded", [1]).serialize()
@@ -101,6 +104,8 @@ def test_commit_and_reveal_weights(local_chain):
             str(uid),
             "--weights",
             str(weights),
+            "--salt",
+            str(salt),
             "--subtensor.network",
             "local",
             "--subtensor.chain_endpoint",
@@ -150,6 +155,8 @@ def test_commit_and_reveal_weights(local_chain):
             str(uid),
             "--weights",
             str(weights),
+            "--salt",
+            str(salt),
             "--subtensor.network",
             "local",
             "--subtensor.chain_endpoint",