Moved load_state() to the neuron.__init__ #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your reasoning is sound, however the miner typically does not have state to load or save. So if this is to be accepted, it would require an implementation of |
ifrit98
suggested changes
Feb 7, 2024
| @@ -99,6 +99,8 @@ def __init__(self, config=None): | |||
| ) | |||
| self.step = 0 | |||
|
|
|||
| self.load_state() | |||
There was a problem hiding this comment.
Miner needs its own null definition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current code, the template.base.validator calls self.sync during initialization which leads to the state being saved (calling self.save_state). And it happens before state being loaded in the neuron.validator initialization. Since the sync function is in the neuron code and it calls save_state there, it's logical to move load_state to neuron initialization. An alternative would be not to call sync during initialization, since it's being called the first thing in the run method.