Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): kas-grants CRUD #80

Merged
merged 14 commits into from
Mar 27, 2024
Merged

feat(core): kas-grants CRUD #80

merged 14 commits into from
Mar 27, 2024

Conversation

suchak1
Copy link
Contributor

@suchak1 suchak1 commented Mar 26, 2024

No description provided.

@suchak1 suchak1 changed the title feature(cli): kas-grants CRUD feat(cli): kas-grants CRUD Mar 26, 2024
@suchak1 suchak1 changed the title feat(cli): kas-grants CRUD feat(core): kas-grants CRUD Mar 26, 2024
jakedoublev
jakedoublev reviewed Mar 27, 2024
View reviewed changes
cmd/kas-grants.go Outdated Show resolved Hide resolved
jakedoublev
jakedoublev reviewed Mar 27, 2024
View reviewed changes
cmd/kas-grants.go Outdated Show resolved Hide resolved
jakedoublev
jakedoublev reviewed Mar 27, 2024
View reviewed changes
cmd/kas-grants.go Outdated Show resolved Hide resolved
jakedoublev
jakedoublev reviewed Mar 27, 2024
View reviewed changes
cmd/kas-grants.go Outdated Show resolved Hide resolved
jakedoublev
jakedoublev reviewed Mar 27, 2024
View reviewed changes
cmd/kas-grants.go Outdated Show resolved Hide resolved
jakedoublev
jakedoublev reviewed Mar 27, 2024
View reviewed changes
cmd/kas-grants.go Outdated Show resolved Hide resolved
jakedoublev
jakedoublev reviewed Mar 27, 2024
View reviewed changes
cmd/kas-grants.go Outdated Show resolved Hide resolved
@jakedoublev
Copy link
Contributor

jakedoublev commented Mar 27, 2024 •
edited
Loading

Great work, @suchak1. Above are some questions, some optional nit picks, and some suggestions. The nit picks are prefaced by Nit: for clarity. Let me know if you'd like to discuss anything.

suchak1 and others added 7 commits March 27, 2024 11:19
@suchak1 @jakedoublev
Update cmd/kas-grants.go
933ffb6 
Co-authored-by: Jake Van Vorhis <83739412+jakedoublev@users.noreply.github.com>
@suchak1
delete check
769ce26
@suchak1 @jakedoublev
Update cmd/kas-grants.go
2a13876 
Co-authored-by: Jake Van Vorhis <83739412+jakedoublev@users.noreply.github.com>
@suchak1 @jakedoublev
Update cmd/kas-grants.go
3590250 
Co-authored-by: Jake Van Vorhis <83739412+jakedoublev@users.noreply.github.com>
@suchak1 @jakedoublev
Update cmd/kas-grants.go
e7d838a 
Co-authored-by: Jake Van Vorhis <83739412+jakedoublev@users.noreply.github.com>
@suchak1
flag labels
21038ca
@suchak1
pass response to HandleSuccess
2747c45
@suchak1 suchak1 merged commit f53b61d into main Mar 27, 2024
5 checks passed
@suchak1 suchak1 deleted the feature/kas-grants branch March 27, 2024 15:38
@suchak1 suchak1 linked an issue Mar 28, 2024 that may be closed by this pull request
Add CLI kas-grants CRUD commands #36
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakedoublev jakedoublev jakedoublev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add CLI kas-grants CRUD commands
2 participants
@suchak1 @jakedoublev