Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(auth): Add support for clientCredentials OIDC login flow #63 #65

Merged
merged 5 commits into from
Mar 19, 2024
Merged

feat(auth): Add support for clientCredentials OIDC login flow #63 #65

merged 5 commits into from
Mar 19, 2024

Conversation

averypfeiffer
Copy link
Contributor

Add support for the following functionality:

  • OIDC Login via clientCredentials flow
  • OS-Agnostic secret, clientId, and OIDC_TOKEN storage (support MacOS, Windows, and Linux, see docs here
  • Add support for reading secret and clientId from keyring, if none is passed to login command
  • Add support for reading OIDC Token from keyring (cache), checking if it has expired, if not using it when instansiating the SDK, and if expired, attempt to retrieve clientId and secret, and grab new OIDC_TOKEN (and also store it)

@jrschumacher jrschumacher changed the title feat(#63): Add support for clientCredentials OIDC login flow feat(auth): Add support for clientCredentials OIDC login flow #63 Mar 12, 2024
@jrschumacher jrschumacher linked an issue Mar 12, 2024 that may be closed by this pull request
Implement storage of auth token for SDK authorization #63
Closed
@jrschumacher
Copy link
Member

Great progress! Excited to give it a try.

averypfeiffer and others added 2 commits March 18, 2024 12:13
@averypfeiffer @jrschumacher
Update pkg/handlers/authLogin.go
dda64a2 
Co-authored-by: Ryan Schumacher <jschumacher@virtru.com>
@averypfeiffer
resolve core Go vulns
95c38ac
@averypfeiffer averypfeiffer merged commit b001351 into main Mar 19, 2024
5 checks passed
@averypfeiffer averypfeiffer deleted the add-auth-command-with-token-storage-logic branch March 19, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrschumacher jrschumacher jrschumacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement storage of auth token for SDK authorization
2 participants
@averypfeiffer @jrschumacher