Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add cli attribute values crud #49

Merged
merged 19 commits into from
Mar 30, 2024
Merged

Conversation

jrschumacher
Copy link
Member

No description provided.

@jrschumacher jrschumacher marked this pull request as ready for review February 15, 2024 21:26
@jrschumacher jrschumacher linked an issue Mar 4, 2024 that may be closed by this pull request
@jakedoublev jakedoublev changed the title feat(policy): add cli attribute values crud feat(core): add cli attribute values crud Mar 29, 2024
@jakedoublev
Copy link
Contributor

Changes I committed:

  1. better error messages (though there's always still room for improvement)
  2. metadata labels to attribute values create/update
  3. more usage of proto message field accessor/getter methods (which I understand help avoid nil pointer panics)
  4. bump to the latest sdk and gencode versions

I also added support for the update calls on attribute values to add/replace/remove members, but I believe members functionality has only been added platform-side on create of values with members, not update of existing values yet. We should probably comment it out to avoid confusion until it's been supported in the service.

jakedoublev
jakedoublev previously approved these changes Mar 29, 2024
@jakedoublev
Copy link
Contributor

opentdf/platform#476 is open and referenced in the TODO with commented out members CLI subcommands

jakedoublev
jakedoublev previously approved these changes Mar 29, 2024
@jrschumacher
Copy link
Member Author

Looks good to me!

@jakedoublev jakedoublev merged commit a7c8955 into main Mar 30, 2024
5 checks passed
@jakedoublev jakedoublev deleted the jrschumacher/issue33 branch March 30, 2024 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CLI attribute values CRUD commands
2 participants