-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(policy): add cli crud for attributes #48
Conversation
flagHelper := cli.NewFlagHelper(cmd) | ||
id := flagHelper.GetRequiredString("id") | ||
|
||
if _, err := h.UpdateAttribute(id); err != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we holding off on an implementation for this until the policy api issues are handled? If so, that makes sense to me.
Policy api issues: [https://github.com/opentdf/platform/issues/115, https://github.com/opentdf/platform/issues/114, https://github.com/opentdf/platform/issues/108]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jakedoublev yea I should have added a comment to let users know it's in flight
{"Namespace", a.Namespace}, | ||
}...).Render(), | ||
) | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to use the same --json
global output flag and "full output" suggestion prompt as with subject mappings?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I'll add this as a separate ticket. Still thinking about how to abstract this in a way where we don't have to think about it.
I think I'll have to do some reflection.
Add CLI CRUD for attributes w/ values
Assuming
export NAMESPACE_ID=752cbd4d-9fa4-4c8e-853c-0dfa2ebc6956