-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add specific school presets for the US #1021
base: main
Are you sure you want to change the base?
Conversation
🍱 Preview the tagging presets of this pull request here: https://pr-1021--ideditor-presets-preview.netlify.app/id/dist/#locale=en. |
This is based on openstreetmap#1021 I reused the school and isced level presets and fields from openstreetmap#1021 whenever possible. It will be important to add the correct translations during the translation process - `school/1-US,DE.json` => "Grundschule" - `school/2-US,DE.json` => "Sekundarschule ohne Oberstufe" - `school/2-DE.json` => "Sekundarschule mit Oberstufe" The ISCED level fields work nicely with the multiCombo by automatically selecting the right preset based on the field combinations. This is a fresh take on and supersedes openstreetmap#331
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isced:level
was a mistake on multiple levels. Much of the criticism directed at the rejected isced:2011:level
and isced_2011_programme
proposals applies equally to isced:level
(which is not an approved tag anyhow).
The problems with isced:level
are particularly acute for the American school system. The proposed presets have tags that should apply to at most 10% of schools in the U.S., but they have names implying that they apply to 46% of schools, not to mention the remaining schools that are known as e.g. elementary schools without saying so in the name. In the vast majority of cases, mappers will unknowingly mistag isced:level
, or they’ll change it from a correct value to an incorrect one. They may not even be able to decide on the correct value of isced:level
because they don’t know which grades the school serves. This completely defeats the purpose of isced:level
, which is to harmonize school classification internationally.
Moreover, this PR would apply the presets to Puerto Rico, which has never had an official mapping from ISCED to the local school system. Puerto Rico has been moving towards the American system since 2018, but a comprehensive import of schools in Puerto Rico applied isced:level
according to the old system.
Any school classification tagging for the U.S. really should use school
instead, in conjunction with the grades
field that was added in openstreetmap/iD@ab68238.
"reference": { | ||
"key": "isced:level" | ||
}, | ||
"name": "Elementary School Grounds" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ISCED level 1 is officially known as “primary” and covers grades 1 through 6. As of last year, this preset applies to only 0.12% of public schools and 9.3% of private schools. However, 29.0% of public schools and 3.2% of private schools have “Elementary” in their name.
"reference": { | ||
"key": "isced:level" | ||
}, | ||
"name": "Middle School Grounds" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ISCED level 2 is officially known as “lower secondary” and covers grades 7 through 9. This preset applies to only 2.5% of public schools and 0.1% of private schools. However, 7.0% of public schools and 0.3% of private schools have “Middle School” in their name, not to mention the 0.7% of public schools that have “Junior High” in their name.
"reference": { | ||
"key": "isced:level" | ||
}, | ||
"name": "High School Grounds" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ISCED level 3 is officially known as “upper secondary” and covers grades 10 through 12 or, alternatively, the first three years of vocational school. This preset applies to 0.9% of public schools and 0.4% of private schools. However, 9.8% of public schools and 4.0% of private schools have “High School” or “Senior High School” (but not “Junior High School”) in their name.
There are 3,514 public K–8 schools across the country, or 3.5% of all public schools, far more than any of the sets of schools that are covered by these presets. |
Thanks for pointing that out @1ec5, I was looking at implementing these changes a couple months ago, and that was probably why I didn't end up opening a PR. I was hoping that Most of the common values for |
@tordans do you want me to repurpose this PR for the changes you made in arch0345#1 or would you prefer updating #331/creating a new PR? |
That’s a good idea. I’d be particularly interested in omitting the “0” value, which came in from an Australian import that misunderstood a unilateral wiki edit that misunderstood the key as a different way of counting ages. Mappers have been logically assuming it refers to kindergarten in some cases. Since there are quite a few likely ranges, I wonder if we need a new |
JFYI because I just came across it, this is in fact how it is documented in https://wiki.openstreetmap.org/wiki/DE:Key:grades#Nach_Land |
Thanks this input! I took a step back and looked at possible alternatives to roll out in Germany, see https://community.openstreetmap.org/t/art-der-schulen-uber-isced-level-school-oder-school-de/104643 |
Yes, that was based on some unilateral edits in 2017 that still partially remain in this table due to subsequent use. Originally, the scheme went from −5 to 28, for lifelong learning from cradle to grave. It has little basis in reality. |
Based off of #331
I decided to make the field semiCombo as K-8 (and less common 6-12) schools exist, however they might not be common enough to warrant it's own option/preset