Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add specific school presets for the DE #1

Open
wants to merge 2 commits into
base: us-schools
Choose a base branch
from

Conversation

tordans
Copy link

@tordans tordans commented Oct 6, 2023

This is based on openstreetmap#1021. Thanks for the inspiration to solve this like you did, @arch0345.

I reused the school and isced level presets and fields from openstreetmap#1021 whenever possible. It will be important to add the correct translations during the translation process

The ISCED level fields work nicely with the multiCombo by automatically selecting the right preset based on the field combinations.

Right now this PR is based on https://github.com/arch0345/id-tagging-schema/tree/us-schools to make comparing changes easier with openstreetmap#1021. I suggest to merge openstreetmap#1021 first and then change the base in this PR to openstreetmap:main.


This is a fresh take on and supersedes openstreetmap#331

This is based on openstreetmap#1021

I reused the school and isced level presets and fields from openstreetmap#1021 whenever possible. It will be important to add the correct translations during the translation process
- `school/1-US,DE.json` => "Grundschule"
- `school/2-US,DE.json` => "Sekundarschule ohne Oberstufe"
- `school/2-DE.json` => "Sekundarschule mit Oberstufe"

The ISCED level fields work nicely with the multiCombo by automatically selecting the right preset based on the field combinations.

This is a fresh take on and supersedes openstreetmap#331
@tordans
Copy link
Author

tordans commented Oct 6, 2023

Oh, I see now that I created a PR against https://github.com/arch0345/id-tagging-schema, that was not my intention … but makes sense :-)

@arch0345 you could either merge this and we propose it as a shared PR in openstreetmap/id-tagging-schema or I will wait until your PR is merged and create a new PR against openstreetmap/id-tagging-schema then…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant