Add specific school presets for the DE #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on openstreetmap#1021. Thanks for the inspiration to solve this like you did, @arch0345.
I reused the school and isced level presets and fields from openstreetmap#1021 whenever possible. It will be important to add the correct translations during the translation process
school/1-US,DE.json
=> "Grundschule"school/2-US,DE.json
=> "Sekundarschule ohne Oberstufe"school/2-DE.json
=> "Sekundarschule mit Oberstufe"The ISCED level fields work nicely with the multiCombo by automatically selecting the right preset based on the field combinations.
Right now this PR is based on https://github.com/arch0345/id-tagging-schema/tree/us-schools to make comparing changes easier with openstreetmap#1021. I suggest to merge openstreetmap#1021 first and then change the base in this PR to
openstreetmap:main
.This is a fresh take on and supersedes openstreetmap#331