consider other tags for labelling features #9588
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
reviewed
May 27, 2023
| ['*', 'addr:housename', '*', 12], | ||
| ['*', 'lock_name', '*', 12], | ||
| ['*', 'distance', '*', 12], | ||
| ['*', 'railway:position', '*', 12], |
There was a problem hiding this comment.
Should this be limited to points? The railway:position documentation says this key can be used on any kind of feature, but it seems to be extremely rare on ways and relations, and all of the presets that use the Milestone Position field are for nodes only.
There was a problem hiding this comment.
sure, we could limit it to points, but also keep in mind that most of the geometry rules in this array have no effect, because of these 3 wildcard entries:
Lines 74 to 76 in 9cf0a20
1ec5
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8966, Closes #9526
This PR considers other name tags when labelling features in the UI and on the map.
These tags are considered:
alt_name,official_name,loc_name,loc_ref,unsigned_ref,seamark:name,sector:name,addr:housename,lock_nameand in some casesdistanceandrailway:position(see #9526)#8707 and #8440 turned out to be controversial but I can't think of any reason why this change would be unwelcome (?)