-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use addr: tags as a fallback name #8440
base: develop
Are you sure you want to change the base?
Conversation
I very much like the idea of using addr:tag values as displayName fallbacks.
I am interested in your opinion on this.
|
That’s a good point. This non-name-based labeling parallels what we’ve already done for route relations, which are labeled in various places based on secondary tags like
These situations all seem reasonable or at least harmless. (It seems unlikely that an address would show up in the turn restriction editor, for example, but it’s probably better to let that happen then complicate the code with a special case.) It is worth noting that some areas have a lot of buildings with addresses but no names, or a lot of address nodes without names. In these areas, the user will see many more labels than before, similar to the effect in openstreetmap-carto. I think that change would be reasonable, but it’ll likely be a significant visual change in some places. The screenshot above shows some “undefined undefined” labels on buildings on the map. Is that because the address format loads too late, or something else? |
@1ec5 Thanks for the comment.
Great vision :) Please disregard it, I did a quick local change to demo the 'multiple features'. |
link - #1524 |
Closes #8744, Closes #7327, Closes #3857, Closes #2001, Closes #1760, Closes #1524
When adding or editing addresses, the changeset upload page is not very helpful since all addresses are just called "Address". This makes it hard to review what changes you have made.
This PR makes use of the
addr:
tags to provide a fallback name for a node/way/relation, if there is noname
orref
tag.