Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always use the ref as the label #9061

Merged
merged 1 commit into from
Jul 19, 2022

Conversation

k-yle
Copy link
Collaborator

@k-yle k-yle commented Apr 4, 2022

Closes #9054

If a feature has a name tag, iD will always use the name as the label. If there is no name tag, iD will use the ref as the label, but only in a specific list of situations.

This list was introduced 9 years ago in 26dfaf8 & 14272ef, and creates a weird inconsistency - all the features in this screenshot have ref=12, but the label is only shown on some features.

image

This PR allows the ref to always be used as a label on any feature. It seems like that was the original intention anyway - #546 (comment)

@tastrax
Copy link
Contributor

tastrax commented May 29, 2022

Hi @k-yle I assume these failures will mean this change wont get into the next update (that I understand may be soon)?

@k-yle
Copy link
Collaborator Author

k-yle commented May 29, 2022

Hey @tastrax, there have been various build issues with iD since early april (e.g. #9101), which were causing the tests to fail. Should be all good now :)

@tastrax
Copy link
Contributor

tastrax commented May 29, 2022

Many thanks, much appreciated.

@tyrasd tyrasd merged commit 645d73a into openstreetmap:develop Jul 19, 2022
@tyrasd tyrasd added the map-renderer An issue with how things are rendered in the map label Jul 19, 2022
@k-yle k-yle deleted the render-ref-as-label branch August 8, 2022 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
map-renderer An issue with how things are rendered in the map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Render golf=hole ref in edit mode
3 participants