-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render golf=hole ref in edit mode #9054
Comments
The more I audit golf courses, the more I think the name key is a bit of a waste on the preset for holes. I only found a couple of courses in all of Australia that had named holes but maybe its just that folks have done the digitising from aerial with no local knowledge? |
It's worth noting that |
ref is rendered on the OSM map but its not rendered in edit mode using the ID editor. That's what I am asking for consideration for ref to be displayed in this case. |
What are the two golf features top right? Is Golf hole one of the lines? Do they also have 12 in the name? |
I am no coder but does it come from here or from the presets? https://github.com/openstreetmap/iD/blob/develop/modules/util/util.js#L247 |
Many thanks - should ref be the last resort after name? In most cases a name , where it exists, should probably be the priority before ref (thinking of all tagging here, not just golf features) |
yep, |
Applied to Miglianico Golf Course... seeing in the ID edit view what one works on is great for orientation, highlighted same hole number used twice on the in and out of the 9th and 18th which run parallel. |
Description
I have recently been auditing golf courses mainly for where folks have added 'name' tags to tees, fairways, bunkers, golf holes. By far the largest error is golf=hole having something like '18th' or '18th Hole' in the name field, i suspect so it shows in the editor interface. Just about all also had the correct hole number as ref. It seems to me folks are adding the name tag just to orientate themselves around the course whilst editing. This is the obvious way to orientate yourself on a golf course (I am not a player)
Would it be beneficial to display the ref tag as the label in the edit interface (same as the standard OSM render)? I think this would prevent many, many folks from also adding a name tag as well.
Screenshots
Render with incorrect use of names (forget the named tees etc)
as incorrectly named objects look in editor - easy to orientate yourself
how a correctly tagged course looks in the editor - harder to orientate around the course
Correctly tagged holes without 'name' tagging (forget the tees etc)
The text was updated successfully, but these errors were encountered: