Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render golf=hole ref in edit mode #9054

Closed
tastrax opened this issue Mar 28, 2022 · 12 comments · Fixed by #9061
Closed

Render golf=hole ref in edit mode #9054

tastrax opened this issue Mar 28, 2022 · 12 comments · Fixed by #9061
Labels
map-renderer An issue with how things are rendered in the map

Comments

@tastrax
Copy link
Contributor

tastrax commented Mar 28, 2022

Description

I have recently been auditing golf courses mainly for where folks have added 'name' tags to tees, fairways, bunkers, golf holes. By far the largest error is golf=hole having something like '18th' or '18th Hole' in the name field, i suspect so it shows in the editor interface. Just about all also had the correct hole number as ref. It seems to me folks are adding the name tag just to orientate themselves around the course whilst editing. This is the obvious way to orientate yourself on a golf course (I am not a player)

Would it be beneficial to display the ref tag as the label in the edit interface (same as the standard OSM render)? I think this would prevent many, many folks from also adding a name tag as well.

Screenshots

golf_1
Render with incorrect use of names (forget the named tees etc)

golf_2
as incorrectly named objects look in editor - easy to orientate yourself

golf_3
how a correctly tagged course looks in the editor - harder to orientate around the course

golf_4
Correctly tagged holes without 'name' tagging (forget the tees etc)

@1ec5
Copy link
Collaborator

1ec5 commented Mar 28, 2022

This would be doable with a change similar to #6188 or #8707. (The display name of a feature in the relation member list or relation membership list can also be the display name on the map.)

/cc @k-yle

@tastrax
Copy link
Contributor Author

tastrax commented Mar 29, 2022

The more I audit golf courses, the more I think the name key is a bit of a waste on the preset for holes. I only found a couple of courses in all of Australia that had named holes but maybe its just that folks have done the digitising from aerial with no local knowledge?

@k-yle
Copy link
Collaborator

k-yle commented Mar 29, 2022

It's worth noting that ref is already rendered in many situations, such as ways tagged as highway=*, waterway=*, building=*, and probably more. Not sure why ref doesn't render in some situations like golf=*

@tastrax
Copy link
Contributor Author

tastrax commented Mar 30, 2022

ref is rendered on the OSM map but its not rendered in edit mode using the ID editor. That's what I am asking for consideration for ref to be displayed in this case.

@k-yle
Copy link
Collaborator

k-yle commented Mar 30, 2022

I can't work out why some of these features show the ref and others don't... (all have ref=12)

image

@tastrax
Copy link
Contributor Author

tastrax commented Mar 30, 2022

What are the two golf features top right? Is Golf hole one of the lines? Do they also have 12 in the name?

@k-yle
Copy link
Collaborator

k-yle commented Mar 30, 2022

yep, they all have 12 as the ref, and no name tag.

Here's an annotated version (click to expand)

annotated

@tastrax
Copy link
Contributor Author

tastrax commented Mar 30, 2022

I am no coder but does it come from here or from the presets?

https://github.com/openstreetmap/iD/blob/develop/modules/util/util.js#L247

@k-yle
Copy link
Collaborator

k-yle commented Apr 4, 2022

I found the list that limits which features can use the ref as a label. I've opened #9061 to propose removing this restriction for ref

@tastrax
Copy link
Contributor Author

tastrax commented Apr 4, 2022

Many thanks - should ref be the last resort after name? In most cases a name , where it exists, should probably be the priority before ref (thinking of all tagging here, not just golf features)

@k-yle
Copy link
Collaborator

k-yle commented Apr 4, 2022

yep, name is preferred over ref - the usual rules from here apply.

@tyrasd tyrasd added the map-renderer An issue with how things are rendered in the map label Jul 19, 2022
@sekerob
Copy link

sekerob commented Sep 28, 2022

Applied to Miglianico Golf Course... seeing in the ID edit view what one works on is great for orientation, highlighted same hole number used twice on the in and out of the 9th and 18th which run parallel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
map-renderer An issue with how things are rendered in the map
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants