Use address as backup label #6188
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quincylvania
added
the
map-renderer
1ec5
reviewed
Apr 16, 2019
| if (!name && entity.tags['addr:housenumber']) { | ||
| name = entity.tags['addr:housenumber']; | ||
| if (entity.tags['addr:street']) { | ||
| name += ' ' + entity.tags['addr:street']; |
There was a problem hiding this comment.
In some countries, the street name comes before the house number. Would it be feasible to use address-formats.json as a guide to how to format these addresses?
| if (!name && entity.tags['addr:housenumber']) { | ||
| name = entity.tags['addr:housenumber']; | ||
| if (entity.tags['addr:street']) { | ||
| name += ' ' + entity.tags['addr:street']; |
There was a problem hiding this comment.
In areas where both buildings and addresses have been mapped or imported, there may still be freestanding address points for units within a multi-tenant building. Adding addr:unit to the display name would disambiguate these closely spaced points.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if this would close fully #1524 but it's at least a half step toward it.