Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't send null exercise_uuids to biglearn-api #1871

Merged
merged 1 commit into from
Jun 7, 2019
Merged

Conversation

Dantemss
Copy link
Member

@Dantemss Dantemss commented Jun 4, 2019

If some exercise has been deleted from the database. Don't ask how they have been deleted...

@Dantemss
Copy link
Member Author

Dantemss commented Jun 4, 2019

Closing. Will fix this issue in biglearn-sparfa-server instead.

@Dantemss Dantemss closed this Jun 4, 2019
@Dantemss Dantemss deleted the fix_biglearn_data branch June 4, 2019 23:09
@Dantemss Dantemss restored the fix_biglearn_data branch June 5, 2019 03:37
@Dantemss
Copy link
Member Author

Dantemss commented Jun 5, 2019

Kevin prefers to fix the invalid events, so this patch should be merged to ensure they do not reoccur.

@Dantemss Dantemss reopened this Jun 5, 2019
@Dantemss Dantemss requested a review from nathanstitt June 5, 2019 16:19
@Dantemss Dantemss merged commit 7b53af5 into master Jun 7, 2019
@Dantemss Dantemss deleted the fix_biglearn_data branch June 7, 2019 16:11
@staxly
Copy link

staxly bot commented Jun 7, 2019

This PR landed in v21.0.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants