Skip to content

Commit

Permalink
bgpd: Remove redundant check for bgp against NULL
Browse files Browse the repository at this point in the history
bgp_orig is never NULL in the code path, and coverity is angry on this.

Let's remove this test at all.

Coverity 1566808

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
  • Loading branch information
ton31337 committed Oct 12, 2023
1 parent 9bc4d9e commit 4e365c5
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions bgpd/bgp_mplsvpn.c
Original file line number Diff line number Diff line change
Expand Up @@ -1225,8 +1225,9 @@ leak_update(struct bgp *to_bgp, struct bgp_dest *bn,
new->extra->vrfleak->parent = bgp_path_info_lock(parent);
bgp_dest_lock_node(
(struct bgp_dest *)parent->net);
if (bgp_orig)
new->extra->vrfleak->bgp_orig = bgp_lock(bgp_orig);

new->extra->vrfleak->bgp_orig = bgp_lock(bgp_orig);

if (nexthop_orig)
new->extra->vrfleak->nexthop_orig = *nexthop_orig;

Expand Down

0 comments on commit 4e365c5

Please sign in to comment.