Update meta.yaml #24
Update meta.yaml #24
Conversation
Updating meta.yml for conda build. Related to: opensim-org/opensim-core#3273 Recommended [here](https://docs.conda.io/projects/conda-build/en/latest/resources/define-metadata.html#run) that the numpy version should be specified under the requirements/run section. This is where we specify the requirements for the runtime environment. They also specified something about specifying `--numpy` with `conda-build` if using this syntax - I haven't built recipes before so I'll leave that part for someone else that knows the usual syntax/where/when to call this. I also deleted the build string because I believe that this should be done automatically if you specify a version for requirements/run (but Im not positive on this one). I think that this string should be built by conda-build to have a unique hash that goes after the python version to specify the dependencies etc. and this is how different requirements (e.g., numpy) are specified.
|
@aymanhab - the original pull request used the wrong environment variable to specify the python/numpy version(s) and thus the CI build failed. I've updated to use |
|
Thanks much for looking into this @gattia I think you're correct that python version is required for the run section as well as the build section. For now we get around it by having the user specify the package consistent with their python but that's not the right way to enforce it. |
|
Will wait and see if the build ends up with correct artifacts/names without the string. I'd hesitate to pin in the numpy version since this has been major headache due to the fact that other packages use different variants so I'd lean to make the version >= what's used for the build, will know more once the build goes through. Thanks for your help 👍 |
|
Had to restore the string/name as it wasn't autogenerated, I uploaded the windows builds to the opensim_admin account on anaconda.org and the packages seem to have the correct dependencies per the info icon, it remains to be seen how this works with other packages that may specify different numpy versions since we're a bit more restrictive now. I'll be uploading the osx builds shortly to the same account and will let you know before moving to the official opensim-org account so we can do more testing. Thanks again for all your help @gattia much appreciated 🏅 |
|
Amazing! Thank you so much, I just did a tiny bit of hacking around with a general hunch you've done a ton here! Hopefully, this helps things out. Let me know when/if you want me to pull the Mac versions and give them a try |
Updating meta.yml for conda build. Related to: opensim-org/opensim-core#3273
Recommended here that the numpy version should be specified under the requirements/run section. This is where we specify the requirements for the runtime environment. They also specified something about specifying
--numpywithconda-buildif using this syntax - I haven't built recipes before so I'll leave that part for someone else that knows the usual syntax/where/when to call this.I also deleted the build string because I believe that this should be done automatically if you specify a version for requirements/run (but Im not positive on this one). I think that this string should be built by conda-build to have a unique hash that goes after the python version to specify the dependencies etc. and this is how different requirements (e.g., numpy) are specified.