NO-JIRA: extensions/Dockerfile: use latest Fedora to generate repo #1583
Conversation
In this stage of the build, we're just using Fedora to generate repodata. Since this is a pretty basic operation, let's just always use the latest Fedora instead of hardcoding a specific version. This ensures that e.g. we're never going to use an EOL Fedora release. This became an issue after 8301c67 ("extensions/Dockerfile: use the FCOS defined fedora.repo to set up container"), which was backported to older RHCOS branches that used EOL Fedora releases. Before, we were using the mirrors, which papered over the fact that the content for EOL releases actually moved to another location. But now that we're using the canonical Fedora server, we're directly exposed to that. Really, we should just stop hardcoding Fedora versions in this repo. We shouldn't be using EOL releases at all as part of our builds or tests. (Obviously a massive offender here is cosa... though that's a discussion of its own.) See also: openshift#1546
openshift-ci
bot
added
the
approved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aaradhak, jlebon, marmijo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
backports openshift#1583 Backports openshift#1583
|
/retest |
|
/label acknowledge-critical-fixes-only |
openshift-ci
bot
added
the
acknowledge-critical-fixes-only
|
/retitle NO-JIRA: extensions/Dockerfile: use latest Fedora to generate repo |
openshift-ci
bot
changed the title
|
@jlebon: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
@jlebon: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
In this stage of the build, we're just using Fedora to generate repodata. Since this is a pretty basic operation, let's just always use the latest Fedora instead of hardcoding a specific version. This ensures that e.g. we're never going to use an EOL Fedora release.
This became an issue after 8301c67 ("extensions/Dockerfile: use the FCOS defined fedora.repo to set up container"), which was backported to older RHCOS branches that used EOL Fedora releases. Before, we were using the mirrors, which papered over the fact that the content for EOL releases actually moved to another location. But now that we're using the canonical Fedora server, we're directly exposed to that.
Really, we should just stop hardcoding Fedora versions in this repo. We shouldn't be using EOL releases at all as part of our builds or tests. (Obviously a massive offender here is cosa... though that's a discussion of its own.)
See also: #1546