Revert "image*.yaml: Enable injection of OCP machine-os metadata by…
#1084
Conversation
… default" This reverts commit f4646dc. We're seeing failures here because as of right now the `machine-os-content` and `rhel-coreos-8` are not aliases; and even if they were it appears that `oc` would need work to handle this.
openshift-ci
bot
added
the
approved
|
Does this imply ART will not be adding the new oscontainer to the release payload for now? Is there something we can link to here with more info on the failures? There's a lot of moving pieces around this so it'd be good to keep a good paper trail. |
|
Status quo is that we have both old and new container image in the release image. |
OK. I asked because I thought the tooling required those labels to be in place but it seems like that's not the case. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, jlebon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/override ci/prow/rhcos-86-build-test-qemu |
|
@cgwalters: Overrode contexts on behalf of cgwalters: ci/prow/rhcos-86-build-test-qemu In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override ci/prow/scos-9-build-test-qemu |
|
@travier: Overrode contexts on behalf of travier: ci/prow/scos-9-build-test-qemu In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@cgwalters: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This was previously enabled (openshift#1048) and then disabled again (openshift#1084) because `oc` doesn't know how to handle multiple images with those labels in the release payload. We'll need to solve this eventually if we want to be able to ship multiple OS images in the payload (that's tracked in openshift#1047), but we don't need to block on this if we can remove the legacy `machine-os-content` at the same time. See also: openshift/driver-toolkit#101 See also: openshift/machine-config-operator#3364
This was previously enabled (openshift#1048) and then disabled again (openshift#1084) because `oc` doesn't know how to handle multiple images with those labels in the release payload. We'll need to solve this eventually if we want to be able to ship multiple OS images in the payload (that's tracked in openshift#1047), but we don't need to block on this if we can remove the legacy `machine-os-content` at the same time. See also: openshift/driver-toolkit#101 See also: openshift/machine-config-operator#3364
This was previously enabled (openshift#1048, openshift#1374) and then disabled again (openshift#1084, openshift#1393). The last time we tried it, the issue was that there were some references remaining in openshift/kubernetes and openshift/release. Those have been cleaned up now: openshift/release#49156 openshift/kubernetes#1805 So... third time's the charm!
This was previously enabled (openshift#1048, openshift#1374) and then disabled again (openshift#1084, openshift#1393). The last time we tried it, the issue was that there were some references remaining in openshift/kubernetes and openshift/release. Those have been cleaned up now: openshift/release#49156 openshift/kubernetes#1805 So... third time's the charm!
… default"
This reverts commit f4646dc.
We're seeing failures here because as of right now the
machine-os-contentandrhel-coreos-8are not aliases; and even if they were it appears thatocwould need work to handle this.