Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api docs should show right return value for build instantiate{binary,} #16157

Merged
merged 2 commits into from
Sep 26, 2017
Merged

api docs should show right return value for build instantiate{binary,} #16157

merged 2 commits into from
Sep 26, 2017

Conversation

jim-minter
Copy link
Contributor

fixes #8345
dependent on kubernetes/kubernetes#51972 merging

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 5, 2017
@jim-minter
Copy link
Contributor Author

/retest

1 similar comment
@jim-minter
Copy link
Contributor Author

/retest

@jim-minter jim-minter assigned bparees and unassigned smarterclayton and deads2k Sep 25, 2017
@jim-minter
Copy link
Contributor Author

/retest

@bparees
Copy link
Contributor

bparees commented Sep 26, 2017

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, jim-minter

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2017
@openshift-ci-robot
Copy link

@jim-minter: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_builds 9850ad2 link /test extended_builds

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 16546, 16398, 16157)

@openshift-merge-robot openshift-merge-robot merged commit bd2c9a2 into openshift:master Sep 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bparees bparees

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API docs wrong for BuildConfig instantiate
6 participants
@jim-minter @bparees @openshift-merge-robot @openshift-ci-robot @smarterclayton @deads2k