Add Virtual Function (VF) flags for SR-IOV Network Operator #18317
Conversation
openshift-ci-robot
added
the
size/M
|
The preview will be available shortly at: |
|
Need to take care, because of this: https://yaml.org/type/bool.html |
| <8> Optional. Replace `<max_tx_rate>` with a maximum transmission rate, in Mbps, for the VF. | ||
| <9> Optional. Replace `<min_tx_rate>` with a minimum transmission rate, in Mbps, for the VF. This value should always be less than or equal to Maximum transmission rate. | ||
| + | ||
| NOTE: Intel NICs do not support the `minTxRate` parameter. |
There was a problem hiding this comment.
Might be good to link the note to corresponding bug so user knows the consequence (this will lead to config daemon failure ).
There was a problem hiding this comment.
Agree with Zenghui's comment about linking to existing but.
| vlanQoS: <vlan_qos> <10> | ||
| spoofChk: "<spoof_check>" <11> | ||
| trust: "<trust_vf>" <12> | ||
| capabilities: <capabilities> <13> |
There was a problem hiding this comment.
Shall the format of capabilities be consistent with ipam ?
| spec: | ||
| networkNamespace: <target_namespace> <3> | ||
| ipam: |- <4> | ||
| ... | ||
| vlan: <vlan> <5> | ||
| resourceName: <sriov_resource_name> <6> | ||
| linkState: <link_state> <7> | ||
| maxTxRate: <max_tx_rate> <8> | ||
| minTxRate: <mix_rx_rate> <9> |
There was a problem hiding this comment.
This should be <min_tx_rate>
| <8> Optional. Replace `<max_tx_rate>` with a maximum transmission rate, in Mbps, for the VF. | ||
| <9> Optional. Replace `<min_tx_rate>` with a minimum transmission rate, in Mbps, for the VF. This value should always be less than or equal to Maximum transmission rate. | ||
| + | ||
| NOTE: Intel NICs do not support the `minTxRate` parameter. |
There was a problem hiding this comment.
Agree with Zenghui's comment about linking to existing but.
|
Hi @lamek, @vikram-redhat suggested I hand this off to you to wrap up so that I can finalize a demo of the API docs generator this week. Thanks! |
|
@jboxman I got it. |
| spec: | ||
| networkNamespace: <target_namespace> <3> | ||
| ipam: |- <4> | ||
| ... | ||
| vlan: <vlan> <5> | ||
| resourceName: <sriov_resource_name> <6> | ||
| linkState: <link_state> <7> | ||
| maxTxRate: <max_tx_rate> <8> | ||
| minTxRate: <mix_rx_rate> <9> |
| vlanQoS: <vlan_qos> <10> | ||
| spoofChk: "<spoof_check>" <11> | ||
| trust: "<trust_vf>" <12> | ||
| capabilities: <capabilities> <13> |
| <8> Optional. Replace `<max_tx_rate>` with a maximum transmission rate, in Mbps, for the VF. | ||
| <9> Optional. Replace `<min_tx_rate>` with a minimum transmission rate, in Mbps, for the VF. This value should always be less than or equal to Maximum transmission rate. | ||
| + | ||
| NOTE: Intel NICs do not support the `minTxRate` parameter. |
|
@jboxman per my comment above I'm going to close out this PR. |
Original PR: pliurh#4